Review Request: Fix CMake Python macros.

[Luca Beltrame]

> On Oct. 27, 2012, 1:32 p.m., Alexander Neundorf wrote:
> > Have a look at http://www.cmake.org/Wiki/CMake_Released_Versions and/or http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix , to find out what changed in which version of CMake.
> > Beside that, I can't really comment on the python-related changes, I don't know much about python.
> >
> 
> Luca Beltrame wrote:
>     Looks like some of the things I'm using require cmake > 2.8.0. Thus, if you agree with this patch, I'll merge things in master only after Tuesday, after your cmake version bump.
> 
> Alexander Neundorf wrote:
>     What do you think requires cmake > 2.8.0 ?
>     
>

Now that CMake 2.8.8 is required for 4.10, I'll discard this review request and post a proper one to be in kdelibs.


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107049/#review21002
-----------------------------------------------------------


On Oct. 26, 2012, 9:50 a.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107049/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2012, 9:50 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Fix CMake Python macros.
> 
> The internal CMake macros in kdelibs for Python are a
> mess, and make installing for different Python versions (2 and 3) very
> hard, especially since some distributions change the Python library name
> slightly.
> 
> The fix is to use proper CMake macros from upstream, FindPythonInterp
> and FindPythonLibs.
> 
> However I'm not sure in which CMake versions these are. If it's 2.6.x, I'll also push to stable branch.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt af7a81573408952240517735ea3f4107a9be77e8 
>   kpythonpluginfactory/CMakeLists.txt 41fa0fed576cafacc4cdaa4f7ca657b41c7beba3 
> 
> Diff: http://git.reviewboard.kde.org/r/107049/diff/
> 
> 
> Testing
> -------
> 
> Compiled with Python 3 and Python 2.
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20121030/dd6b9a77/attachment-0001.html>