Review Request: Fix CMake Python macros.

Alexander Neundorf neundorf at kde.org
Sun Oct 28 08:56:09 UTC 2012


On Sunday 28 October 2012, Luca Beltrame wrote:
> In data domenica 28 ottobre 2012 08:36:07, Alexander Neundorf ha scritto:
> > What do you think requires cmake > 2.8.0 ?
> 
> Python_ADDITIONAL_VERSIONS in FindPythonInterp.cmake and
> FindPythonLibs.cmake, which I use to work around an issue where
> FindPythonLibs.cmake from upstream cmake would not pick up the right
> Python library in case of co-installed Python versions.
> 
> SET(Python_ADDITIONAL_VERSIONS "${PYTHON_VERSION_MAJOR}.
> ${PYTHON_VERSION_MINOR}")
> 
> According to the compatibility matrix, this is only available from cmake >
> 2.8.0.
> 
> BTW, what constitutes source compatibility for cmake macros? I plan on
> fixing PythonMacros in kdelibs once this is settled, but I need to know
> before breaking anything.

Basically, working cmake code which uses the macro must continue to work 
without needing modifications.
I.e. the macro must still exist with the same name and it must still work if 
called with the same arguments and produce working results.

Alex



More information about the Kde-buildsystem mailing list