Review Request: Fix CMake Python macros.

Luca Beltrame einar at heavensinferno.net
Fri Oct 26 09:50:21 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107049/
-----------------------------------------------------------

(Updated Oct. 26, 2012, 9:50 a.m.)


Review request for Build System.


Changes
-------

Added auto detection of Python packages dir, with manual override.


Description
-------

Fix CMake Python macros.

The internal CMake macros in kdelibs for Python are a
mess, and make installing for different Python versions (2 and 3) very
hard, especially since some distributions change the Python library name
slightly.

The fix is to use proper CMake macros from upstream, FindPythonInterp
and FindPythonLibs.

However I'm not sure in which CMake versions these are. If it's 2.6.x, I'll also push to stable branch.


Diffs (updated)
-----

  CMakeLists.txt af7a81573408952240517735ea3f4107a9be77e8 
  kpythonpluginfactory/CMakeLists.txt 41fa0fed576cafacc4cdaa4f7ca657b41c7beba3 

Diff: http://git.reviewboard.kde.org/r/107049/diff/


Testing
-------

Compiled with Python 3 and Python 2.


Thanks,

Luca Beltrame

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20121026/3fbd62e5/attachment.html>


More information about the Kde-buildsystem mailing list