Review Request: Support Python 3.2's new method of handling byte compiled files in PythonMacros.cmake

[Luca Beltrame]

> On Oct. 4, 2012, 7:05 p.m., Alexander Neundorf wrote:
> > Looks straightforward and obvious.
> > Beside that, I don't know much about python byte code compiling.
> >

Actually it's still not perfect because it does not install files correctly.

I tried to

IF(PYTHON_SHORT_VERSION GREATER 3.1)
    INSTALL(FILES ${_bin_pyc} DESTINATION ${DESINATION_DIR}/__pycache__)

but it saves them in / rather than in the destination folder. What am I doing wrong?


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106707/#review19923
-----------------------------------------------------------


On Oct. 3, 2012, 10:43 a.m., Luca Beltrame wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106707/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 10:43 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Python 3.2 changed the compile mechanism by creating a __pycache__ directory. This obviously breaks a lot of stuff that assumed that pyc files were stored in the same directory as the py files. This change adds a check, and adjusts files only in case Python 3.2 is found. Notice that currently I have way of testing if the suffix (*cpython) is the same on all supported OSes.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/PythonMacros.cmake 774c6b2d8eb5f9bafaf7e73da1108bd347a73667 
> 
> Diff: http://git.reviewboard.kde.org/r/106707/diff/
> 
> 
> Testing
> -------
> 
> No more errors are produced when building PyKDE4 with Python 3.2.3
> 
> 
> Thanks,
> 
> Luca Beltrame
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20121004/22cd5c89/attachment-0001.html>