CMake 2.8.8 will be required for kdelibs 4.10 starting October 30th

[Stephen Kelly]

Alexander Neundorf wrote:

> On Tuesday 06 November 2012, Stephen Kelly wrote:
>> Alexander Neundorf wrote:
>> > On Friday 26 October 2012, Alexander Neundorf wrote:
>> >> On Thursday 18 October 2012, Alexander Neundorf wrote:
>> >> > Hi,
>> >> > 
>> >> > in kdelibs we require since more than 2 years cmake .2.6.4, since
>> >> > then many improvements and fixes have gone into cmake, and we cannot
>> >> > make use of them.
>> > 
>> > Ok, I pushed this change to the kdelibs 4.10 branch.
>> 
>> Thanks.
>> 
>> So what can we now do in kde buildsystems to modernize them and make them
>> ready for KF5?
>> 
>>  * Use find_package instead of macro_optional_find_package?
> 
> Yes.
> When committing those changes, it would probably be good to mention in the
> commit message that packages can be skipped by initially setting
> CMAKE_DISABLE_FIND_PACKAGE_<package> to TRUE.

Done in kdepimlibs.

> 
>>  * Port from macro_feature_log to set_package_properties?
> 
> Yes.

Done in kdepimlibs.

>>  * Port to CMAKE_AUTOMOC? Would probably require a way to disable
>>  automoc4.

You didn't comment on this part. Is that because you are reading/considering 
my patch? I think it's an important patch to get in to the next release, as 
kdepimlibs depends on the latest released version of kdelibs.

>>  * Use set(CMAKE_LINK_INTERFACE_LIBRARIES "") as
>>  kde4_add_library does.
> 
> Maybe. This would be in FindKDE4Internal.cmake, right ?

Or downstream in kdepimlibs/CMakeLists.txt. It will probably make it 
possible to do some porting away from kde4_add_library to add_library, where 
the kde4_add_library features are not used. That's a porting step we'll need 
to do anyway when porting to KF5, so better to do it now and make porting 
later easier.

> I think this wouldn't help a lot. It is hidden in kde4_add_library() now,
> and then it would be hidden in FindKDE4Internal.cmake.
> Ok, then it would also apply to libraries which are built using the normal
> add_library() call.... there are not many of those.
> 
>>  * Port to GenerateExportHeader?
> 
> You know that better than I do.

Ok, I'll look into this later.

Thanks,

Steve.