Review Request: Use exported targets the right way.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104545/#review13752
-----------------------------------------------------------


This review has been submitted with commit c556b64d17e4aabd44cf612d274d807f89461a5c by Raphael Kubo da Costa to branch master.

- Commit Hook


On April 11, 2012, 5:05 a.m., Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104545/
> -----------------------------------------------------------
> 
> (Updated April 11, 2012, 5:05 a.m.)
> 
> 
> Review request for Build System and Trever Fischer.
> 
> 
> Description
> -------
> 
> Besides the exported targes file and the Config file having different purposes, so far applications wishing to use libkcompactdisc (such as kscd) had to use the full imported target name (which was weirdly named `KDE::Libkcompactdisckcompactdisc') instead of a variable such as `LIBKCOMPACTDISC_LIBRARIES'.
>     
> We now have a LibkcompactdiscConfig.cmake.in file which is used to generate a proper Config file. It currently defines the `LIBKCOMPACTDISC_INCLUDE_DIRS' and `LIBKCOMPACTDISC_LIBRARIES' variables and includes the exported targets file, which is now named LibkcompactdiscTargets.cmake.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b41dbf5 
>   LibkcompactdiscConfig.cmake.in PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/104545/diff/
> 
> 
> Testing
> -------
> 
> With the analogous change <https://git.reviewboard.kde.org/r/104544/> made to libkcddb I can finally build kscd again.
> 
> 
> Thanks,
> 
> Raphael Kubo da Costa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120512/f6d35bf0/attachment.html>