Review Request: Control optional Xinerama support

Alexander Neundorf neundorf at kde.org
Wed May 2 16:01:20 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104698/#review13276
-----------------------------------------------------------

Ship it!


Looks like it should be ok.


- Alexander Neundorf


On May 1, 2012, 7:39 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104698/
> -----------------------------------------------------------
> 
> (Updated May 1, 2012, 7:39 p.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> Xinerama libraries are currently only used by ksplash, and detection is automagic.
> 
> This patch adds an option allowing compile without Xinerama even if it's installed, defaulting to ON as to not change existing behaviour.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 52288c04f3b83a123afdbe7a1f1b061cb76c9a5a 
>   ConfigureChecks.cmake ab4990f28f27748ff6c9fa8f1c0c9e46d17a9904 
> 
> Diff: http://git.reviewboard.kde.org/r/104698/diff/
> 
> 
> Testing
> -------
> 
> Configures and compiles fine, and scanelf reports Xinerama link when compiled with -DWITH_XINERAMA=ON, and no link when off.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120502/de060ad1/attachment.html>


More information about the Kde-buildsystem mailing list