Review Request: KActivities fails to configure without Nepomuk

Ivan Čukić ivan.cukic at kde.org
Thu Jun 21 08:41:56 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105251/#review14937
-----------------------------------------------------------


sqlite plugin should be build even without nepomuk. the 'nepomuk required' in the plugin's cmakelists.txt is the problem.

i'll see to it in a minute.

- Ivan Čukić


On June 21, 2012, 8:17 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105251/
> -----------------------------------------------------------
> 
> (Updated June 21, 2012, 8:17 a.m.)
> 
> 
> Review request for Build System and Ivan Čukić.
> 
> 
> Description
> -------
> 
> cmake -DWITH_Nepomuk fails because it is required for the sqlite plugin, despite being optional for the rest of the package.
> 
> This patch simply avoids trying to build that plugin if Nepomuk is disabled.
> 
> 
> Diffs
> -----
> 
>   service/plugins/CMakeLists.txt 2276d6b430c08117481823332f07e2c384f0c06a 
> 
> Diff: http://git.reviewboard.kde.org/r/105251/diff/
> 
> 
> Testing
> -------
> 
> cmake detects Nepomuk correctly depending on passed options.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120621/4137fd0c/attachment-0001.html>


More information about the Kde-buildsystem mailing list