[PATCH 1/3] Pass additional gcc compiler flags regardless of the OS.

Alexander Neundorf neundorf at kde.org
Tue Jul 31 18:14:02 UTC 2012


On Monday 30 July 2012, Raphael Kubo da Costa wrote:
> Raphael Kubo da Costa <rakuco at FreeBSD.org> writes:
> > Building picmi on FreeBSD was failing because of -Wlong-long, which
> > should have been disabled by default via _KDE4_PLATFORM_DEFINITIONS.
> > 
> > However, commit 4e0bbaee43ecf3fe8c880212da8ad6ca96978c2a made the
> > additional gcc flags be passed only when building on Linux (commit
> > 9986ec68bbbd55a0b7ad589752a0ed0d03ece639 extended that to GNU Hurd)
> > for no apparent reason.
> > 
> > Thus sort of restore the behavior present in commit
> > 4d1789f40ed1cc6e34e55b9edc119ee6389e1368, with the difference that the
> > flags are passed even on Windows and other systems.
> 
> Any comments on this one?

I trust your judgement on this.

Alex
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120731/9e764fc9/attachment.html>


More information about the Kde-buildsystem mailing list