Review Request: properly pass the NOGUI flag

[Stephen Kelly]

On Monday, July 30, 2012 21:51:02 Alexander Neundorf wrote:
> On Monday 30 July 2012, David Faure wrote:
> > On Monday 30 July 2012 04:20:18 Raphael Kubo da Costa wrote:
> > > As for "who uses NOGUI",
> > > http://lxr.kde.org/search?filestring=&string=kde4_add_unit_test+NOGU
> > > I
> > 
> > NOGUI seems to be missing in KDE Frameworks / extra-cmake-modules
> > though.
> > (unrelated to this review request, but it reminded me to bring this up)
> 
> The idea is that this is not necessary anymore.
> Instead there is a global flag to enable the GUI stuff for Windows and OSX,
> added to cmake in 2.8.8.
> 
> Stephen, is this right ?

Yes, but what David wants is the opposite. We globally set 

set(CMAKE_WIN32_EXECUTABLE ON)

in kde-modules/KDECMakeSettings.cmake

and the macro in modules/ECMMarkNonGuiExecutable.cmake

can be used to disable it. So, replace NOGUI with 

ecm_mark_nongui_executable(the_target)

Thanks,

-- 
Stephen Kelly <stephen.kelly at kdab.com> | Software Engineer
KDAB (Deutschland) GmbH & Co.KG, a KDAB Group Company
www.kdab.com || Germany +49-30-521325470 || Sweden (HQ) +46-563-540090
KDAB - Qt Experts - Platform-Independent Software Solutions
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120731/403770ee/attachment.sig>