FindSharedDesktopOntologies.cmake for KF5

Alexander Neundorf neundorf at kde.org
Thu Jan 19 16:41:39 UTC 2012


On Thursday 19 January 2012, Yury G. Kudryashov wrote:
> Alexander Neundorf wrote:
> > On Wednesday 18 January 2012, Yury G. Kudryashov wrote:
> >> Sune Vuorela wrote:
> >> > Wouldn't it be a even better idea to get SDO to provide a
> >> > SharedDesktopOntologiesConfig.cmake file ?
> >> 
> >> Look at the attached FindSharedDesktopOntologies.cmake. It is a wrapper
> >> around SharedDesktopOntologiesConfig.cmake.
> > 
> > In this case, it should be good enough to do
> > 
> > find_package_handle_standard_args(SharedDesktopOntologies CONFIG_MODE)
> 
> I'll look at the sources of FPHSA and try to improve its documentation.
> Currently it just says "it does all the magic".


Yes, please :-)

> >> The new attached version adds feature_summary.
> > 
> > IMO this should also be in the Config.cmake file, since it contains
> > package- specific information.
> 
> I disagree. Both URL and DESCRIPTION should be available if SDO is not
> installed as this information is used in "not found" message.

Yes, that's true.
 
Alex


More information about the Kde-buildsystem mailing list