Review Request: Install LibKexiv2Config.cmake

Yury Georgievich Kudryashov urkud at ya.ru
Tue Jan 17 23:58:52 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103701/
-----------------------------------------------------------

(Updated Jan. 17, 2012, 11:58 p.m.)


Review request for Build System and Digikam.


Changes
-------

Avoid using WBCVF.


Description
-------

Now
find_package(LibKexiv2 NO_MODULE)
finds LibKexiv2, removing need for large FindLibKexiv2.cmake script.

I've decided to install LibKexiv2Config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.

P.S.: I think about moving large parts to a macro.


Diffs (updated)
-----

  CMakeLists.txt 0ecd233 
  LibKexiv2Config-external.cmake.in PRE-CREATION 
  LibKexiv2Config.cmake.in PRE-CREATION 
  LibKexiv2ConfigVersion.cmake.in PRE-CREATION 
  libkexiv2/CMakeLists.txt 8a6b822 

Diff: http://git.reviewboard.kde.org/r/103701/diff/diff


Testing
-------

$ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
$ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK


Thanks,

Yury Georgievich Kudryashov

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120117/78f1df69/attachment-0001.html>


More information about the Kde-buildsystem mailing list