Review Request: Install LibKexiv2Config.cmake

[Yury Georgievich Kudryashov]

> On Jan. 15, 2012, 1:45 p.m., Alexander Neundorf wrote:
> > IF(WIN32 AND NOT CYGWIN)
> >     SET(DEF_CMAKEFILES_INSTALL_DIR CMake)
> > ELSE()
> >     SET(DEF_CMAKEFILES_INSTALL_DIR ${LIB_INSTALL_DIR}/cmake/LibKexiv2)
> > ENDIF()
> > 
> > Why is WIN32 special cased ?
> >

`man cmake` says that cmake does not look into $prefix/lib/cmake/name on Windows. I took this code from http://www.cmake.org/Wiki/CMake/Tutorials/How_to_create_a_ProjectConfig.cmake_file

I've just realized that probably on windows LIB_INSTALL_DIR points to $prefix, not $prefix/lib. In this case this trick is not needed. Am I right?


- Yury Georgievich


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103701/#review9830
-----------------------------------------------------------


On Jan. 14, 2012, 9:24 p.m., Yury Georgievich Kudryashov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103701/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2012, 9:24 p.m.)
> 
> 
> Review request for Build System and Digikam.
> 
> 
> Description
> -------
> 
> Now
> find_package(LibKexiv2 NO_MODULE)
> finds LibKexiv2, removing need for large FindLibKexiv2.cmake script.
> 
> I've decided to install LibKexiv2Config.cmake, not Kexiv2Config.cmake to avoid conflicts with FindKexiv2.cmake from kdelibs.
> 
> P.S.: I think about moving large parts to a macro.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0ecd233 
>   LibKexiv2Config-external.cmake.in PRE-CREATION 
>   LibKexiv2Config.cmake.in PRE-CREATION 
>   libkexiv2/CMakeLists.txt 8a6b822 
> 
> Diff: http://git.reviewboard.kde.org/r/103701/diff/diff
> 
> 
> Testing
> -------
> 
> $ cmake .. -DCMAKE_INSTALL_PREFIX=$PWD/../install; cd ..;
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=EXIST
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=COMPILE
> $ cmake --find-package -DCMAKE_PREFIX_PATH=$PWD/i -DNAME=LibKexiv2 -DCOMPILER_ID=GNU -DLANGUAGE=CXX -DMODE=LINK
> 
> 
> Thanks,
> 
> Yury Georgievich Kudryashov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120115/565d9631/attachment.html>