Review Request: Add option to control PAM support
Christophe Giboudeaux
cgiboudeaux at gmx.com
Fri Feb 3 12:36:40 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103818/#review10314
-----------------------------------------------------------
Ship it!
Please commit after fixing the last issue.
ConfigureChecks.cmake
<http://git.reviewboard.kde.org/r/103818/#comment8508>
This change is also not needed.
the cmake/modules dir is already included by the main CMakeLists.txt
- Christophe Giboudeaux
On Feb. 2, 2012, 11:28 a.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103818/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2012, 11:28 a.m.)
>
>
> Review request for Build System.
>
>
> Description
> -------
>
> kcheckpass and KDM support being built without PAM, but this selection is currently automagic.
>
> This patch adds a WITH_PAM option, and makes sure that the patched cmake modules are preferred over the system ones.
>
>
> Diffs
> -----
>
> ConfigureChecks.cmake fe06d9e
> cmake/modules/UnixAuth.cmake 904f0cb
>
> Diff: http://git.reviewboard.kde.org/r/103818/diff/diff
>
>
> Testing
> -------
>
> For me, both kcheckpass and KDM link against libcrypt instead of PAM and work fine when -DWITH_PAM=no is specified.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120203/3fb97cb6/attachment.html>
More information about the Kde-buildsystem
mailing list