Review Request: Add option to control PAM support

[Christophe Giboudeaux]

> On Jan. 29, 2012, 4:42 p.m., Alexander Neundorf wrote:
> > The change in FindPAM.cmake is wrong.
> > FindPAM.cmake does not care whether WITH_PAM is TRUE or not, when called, it will search PAM.
> > If WITH_PAM is disabled, FindPAM.cmake will not be executed, and additionally all PAM_* variables will be set to empty.
> > It should work without the change in FindPAM.cmake.
> 
> Michael Palimaka wrote:
>     That is intended behaviour. It should be possible to compile kcheckpass and KDM without PAM support, even if PAM is present on the system.
> 
> Theo Chatzimichos wrote:
>     Hello Alexander, please have a look at the following gentoo bugs [1] [2]. ossi verified the issue (from #kde-devel):
>     <ossi> tampakrap: seems like it got lost during the cmake migration. too bad
>     <ossi> actually, i was assuming that it is possible to manually set PAM_LIBRARY to NOTFOUND and cmake wouldn't try to find it again
>     
>     [1] https://bugs.gentoo.org/show_bug.cgi?id=398333
>     [2] https://bugs.gentoo.org/show_bug.cgi?id=398331

That doesn't change anything. The FindPAM.cmake change is still wrong:
Changing find_package to macro_optional_find_package lets you use -DWITH_PAM=FALSE. 
If you use this option, FindPAM.cmake is not parsed.


- Christophe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103818/#review10198
-----------------------------------------------------------


On Jan. 31, 2012, 7:16 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103818/
> -----------------------------------------------------------
> 
> (Updated Jan. 31, 2012, 7:16 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> kcheckpass and KDM support being built without PAM, but this selection is currently automagic.
> 
> This patch adds a WITH_PAM option, and makes sure that the patched cmake modules are preferred over the system ones.
> 
> 
> Diffs
> -----
> 
>   ConfigureChecks.cmake fe06d9e 
>   cmake/modules/FindPAM.cmake 3499836 
>   cmake/modules/UnixAuth.cmake 904f0cb 
> 
> Diff: http://git.reviewboard.kde.org/r/103818/diff/diff
> 
> 
> Testing
> -------
> 
> For me, both kcheckpass and KDM link against libcrypt instead of PAM and work fine when -DWITH_PAM=no is specified.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120201/7dff5544/attachment.html>