Review Request: Port kdelibs to feature_summary

Alexander Neundorf neundorf at kde.org
Sun Dec 30 15:53:27 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108002/#review24263
-----------------------------------------------------------

Ship it!


Looks ok in general.
If everything#s fine for you, go ahead and commit :-)


- Alexander Neundorf


On Dec. 29, 2012, 1:47 p.m., Christophe Giboudeaux wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108002/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2012, 1:47 p.m.)
> 
> 
> Review request for Build System, kdelibs and Alexander Neundorf.
> 
> 
> Description
> -------
> 
> This patch replaces all the macro_log_feature entries with feature_summary.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0030b30 
>   dnssd/CMakeLists.txt 4a44acf 
>   kdecore/CMakeLists.txt b147f22 
>   kdecore/auth/ConfigureChecks.cmake ff17ff0 
>   kdecore/compression/ConfigureChecks.cmake 8edd173 
>   kdeui/tests/proxymodeltestsuite/CMakeLists.txt 0c9a129 
>   kdewebkit/CMakeLists.txt 21b2c5c 
>   kdoctools/CMakeLists.txt 26a9231 
>   khtml/CMakeLists.txt 99034cc 
>   kimgio/CMakeLists.txt 26329c0 
>   kioslave/http/CMakeLists.txt 95ed9cf 
>   kjs/CMakeLists.txt ef3c5e8 
>   mimetypes/CMakeLists.txt 003951e 
>   solid/solid/CMakeLists.txt b7dcc97 
>   sonnet/plugins/CMakeLists.txt 9d69005 
> 
> Diff: http://git.reviewboard.kde.org/r/108002/diff/
> 
> 
> Testing
> -------
> 
> No issue detected. CMake detects the same dependencies as before.
> 
> 
> Thanks,
> 
> Christophe Giboudeaux
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20121230/ea49a0c3/attachment.html>


More information about the Kde-buildsystem mailing list