[kdepimlibs] /: Interim hack to make everything which depends on kdepimlibs build again.
Yury G. Kudryashov
urkud.urkud at gmail.com
Thu Dec 20 19:30:02 UTC 2012
Andreas Pakulat wrote:
> On Thu, Dec 20, 2012 at 2:47 PM, Christophe Giboudeaux
> <cgiboudeaux at gmx.com> wrote:
>> On Thursday 20 December 2012 14:12:17 Yury G. Kudryashov wrote:
>>> I don't think that adding REQUIRED is the right thing to do. Probably,
>>> if(NOT TARGET nepomukcore)
>>> find_package(NepomukCore REQUIRED NO_MODULE)
>>> find_package(NepomukCore NO_MODULE)
>> Generally speaking, I'm against using find_package() in config files or I
>> see no valid reason to only look for nepomukcore, you should also look
>> for KDE4, Qt4, phonon and qjson which are all listed in
>> KDEPimLibsLibraryTargetsWithPrefix and why not extend it to build
>> dependencies and add libical, boost and all other dependencies ?
> The config file should indeed ensure that all targets it needs are
> being set up, so yes you should also have a find_package(KDE4) in
> there. You don't need one for Qt4 since KDE4 requires Qt4 and hence
> searches for it. If kdelibs require nepomuk these days then you
> wouldn't need the extra find_package(Nepomuk) either when doing a
BTW, what about adding Boost_INCLUDE_DIRS to KDEPIMLIBS_INCLUDE_DIRS?
akonadi/item.h #includes quite a few boost headers.
I have a graft-style layout (each package in a dedicated directory), and a
few packages (say, kipi-plugins) fail to build because of this issue.
Yury G. Kudryashov,
mailto: urkud.urkud at gmail.com
More information about the Kde-buildsystem