Review Request: Fix kwin build with GLES

Michael Palimaka kde at
Sat Apr 14 18:42:56 UTC 2012

This is an automatically generated e-mail. To reply, visit:

(Updated April 14, 2012, 6:42 p.m.)

Review request for Build System and kwin.


Another patch update, as per feedback.


When compiling kwin with GLES and without OpenGL, build fails because some parts do not realise that GLES is being used. This is because of KWIN_HAVE_OPENGLES_COMPOSITING being previously removed in 026e0f418d27466a6fe855bbe95a50ea5dd71b4b and some references being missed.

This patch switches the conditional to OPENGLES_FOUND, so that -DKWIN_HAVE_OPENGLES is again passed to the build disabling OpenGL-only features.

Diffs (updated)

  kwin/kcmkwin/kwinscreenedges/CMakeLists.txt 282735087ba7ecd37ec96bdc05e8ef0a03e4dc8e 
  kwin/effects/CMakeLists.txt 6f0ef11e87c6cb5895c5843fa5bb91cf72a6e800 
  kwin/kcmkwin/kwincompositing/CMakeLists.txt 2d420c06941138eefb7058458549da4df42bd70a 



Builds with OpenGL on & GLES off, OpenGL off & GLES on, and both OpenGL & GLES on complete as expected. In each case, the appropriate OpenGL or GLES-specific libraries were built.


Michael Palimaka

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Kde-buildsystem mailing list