Review Request: Fix kwin build with GLES

[Martin Gräßlin]

> On April 13, 2012, 7:39 p.m., Martin Gräßlin wrote:
> > I just re-setup my Jenkins build for without OpenGL and with OpenGL ES and it compiled successfully. Output can be found on paste: http://paste.kde.org/456872/ (only cmake log as paste does not like the complete log and I cannot point you to my jenkins as it's running in a VM)
> > 
> > Please check whether I do something wrong that it succeeds :-)
> 
> Michael Palimaka wrote:
>     Thanks for taking the time to look at this. :)
>     
>     This is my failed build log: http://paste.kde.org/457136/
>     
>     Adding -DKWIN_PLASMA_ACTIVE=ON, as from your log, seems to be the culprit - with it, compile succeeds for me.

> Adding -DKWIN_PLASMA_ACTIVE=ON, as from your log, seems to be the culprit - with it, compile succeeds for me.
Yes, I also figured out why: it disables building of the KCMs and also disables building of logout effect. Which means the code just never got compiled which is the reason why my jenkins never reported it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104558/#review12408
-----------------------------------------------------------


On April 14, 2012, 4:44 p.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104558/
> -----------------------------------------------------------
> 
> (Updated April 14, 2012, 4:44 p.m.)
> 
> 
> Review request for Build System and kwin.
> 
> 
> Description
> -------
> 
> When compiling kwin with GLES and without OpenGL, build fails because some parts do not realise that GLES is being used. This is because of KWIN_HAVE_OPENGLES_COMPOSITING being previously removed in 026e0f418d27466a6fe855bbe95a50ea5dd71b4b and some references being missed.
> 
> This patch switches the conditional to OPENGLES_FOUND, so that -DKWIN_HAVE_OPENGLES is again passed to the build disabling OpenGL-only features.
> 
> 
> Diffs
> -----
> 
>   kwin/effects/CMakeLists.txt 6f0ef11e87c6cb5895c5843fa5bb91cf72a6e800 
>   kwin/kcmkwin/kwincompositing/CMakeLists.txt 2d420c06941138eefb7058458549da4df42bd70a 
>   kwin/kcmkwin/kwinscreenedges/CMakeLists.txt 282735087ba7ecd37ec96bdc05e8ef0a03e4dc8e 
> 
> Diff: http://git.reviewboard.kde.org/r/104558/diff/
> 
> 
> Testing
> -------
> 
> Builds with OpenGL on & GLES off, OpenGL off & GLES on, and both OpenGL & GLES on complete as expected. In each case, the appropriate OpenGL or GLES-specific libraries were built.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120414/0767719d/attachment.html>