Review Request: Fix kwin build with GLES
Thomas Lübking
thomas.luebking at web.de
Thu Apr 12 19:16:43 UTC 2012
> On April 12, 2012, 7:08 p.m., Alexander Neundorf wrote:
> > I can't find the commit 026e0f418d27466a6fe855bbe95a50ea5dd71b4b.
> > Can you post a link to it ?
> > (how do I search for this properly in quickgit ?)
https://projects.kde.org/projects/kde/kde-workspace/repository/revisions/026e0f418d27466a6fe855bbe95a50ea5dd71b4b
try "gg:commit 026e0f418d27466a6fe855bbe95a50ea5dd71b4b" for the fun of it ;-)
finds http://osdir.com/ml/kde-commits/2011-08/msg04066.html which loads faster but is not marked up
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104558/#review12366
-----------------------------------------------------------
On April 12, 2012, 4:08 p.m., Michael Palimaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104558/
> -----------------------------------------------------------
>
> (Updated April 12, 2012, 4:08 p.m.)
>
>
> Review request for Build System and kwin.
>
>
> Description
> -------
>
> When compiling kwin with GLES and without OpenGL, build fails because some parts do not realise that GLES is being used. This is because of KWIN_HAVE_OPENGLES_COMPOSITING being previously removed in 026e0f418d27466a6fe855bbe95a50ea5dd71b4b and some references being missed.
>
> This patch switches the conditional to OPENGLES_FOUND, so that -DKWIN_HAVE_OPENGLES is again passed to the build disabling OpenGL-only features.
>
>
> Diffs
> -----
>
> kwin/effects/CMakeLists.txt 6f0ef11e87c6cb5895c5843fa5bb91cf72a6e800
> kwin/kcmkwin/kwincompositing/CMakeLists.txt 2d420c06941138eefb7058458549da4df42bd70a
> kwin/kcmkwin/kwinscreenedges/CMakeLists.txt 282735087ba7ecd37ec96bdc05e8ef0a03e4dc8e
>
> Diff: http://git.reviewboard.kde.org/r/104558/diff/
>
>
> Testing
> -------
>
> Builds with OpenGL on & GLES off, OpenGL off & GLES on, and both OpenGL & GLES on complete as expected. In each case, the appropriate OpenGL or GLES-specific libraries were built.
>
>
> Thanks,
>
> Michael Palimaka
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120412/b3bcdbce/attachment.html>
More information about the Kde-buildsystem
mailing list