Review Request: Control optional kipi support

Alexander Neundorf neundorf at kde.org
Wed Apr 11 16:11:26 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104546/#review12329
-----------------------------------------------------------


You don't have to include(MacroOptionalFindPackage), the include(MacroLibrary) includes all those already.
While at it, you can also remove the other include(Macro.+) calls except the one including MacroLibrary.


- Alexander Neundorf


On April 11, 2012, 10:17 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104546/
> -----------------------------------------------------------
> 
> (Updated April 11, 2012, 10:17 a.m.)
> 
> 
> Review request for Build System.
> 
> 
> Description
> -------
> 
> In ksnapshot, kipi support is already optional. This patch allows the user to control the support, instead of making it automagic.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9f81f5d8ac6606cdb589c4f1a4b399e12d3fda98 
> 
> Diff: http://git.reviewboard.kde.org/r/104546/diff/
> 
> 
> Testing
> -------
> 
> Control works correctly locally. Patch used downstream for about a year with no issues reported.
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120411/c554dd2c/attachment.html>


More information about the Kde-buildsystem mailing list