Review Request: Fix underlinking in KDM
Michael Palimaka
kde at scribeofthenile.com
Sat Apr 7 15:56:04 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104492/
-----------------------------------------------------------
(Updated April 7, 2012, 3:56 p.m.)
Review request for Build System.
Changes
-------
Updated patch to correct issues raised in feedback.
Description
-------
When using the gold linker, building KDM with kerberos support fails due to underlinking: kdm/backend/krb5auth.c requires error_message() from libcom_err.
This patch adds a check for the library and passes it for linking when necessary.
Diffs (updated)
-----
kdm/ConfigureChecks.cmake 0f969f73780e0b45edcb894084e0a3aaa8f72d69
kdm/backend/CMakeLists.txt e94a3b9c68b0da0b5f2ef794e2e67cc7f4c3db5f
Diff: http://git.reviewboard.kde.org/r/104492/diff/
Testing
-------
Local compilation without issues, both with and without kerberos support enabled.
Thanks,
Michael Palimaka
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-buildsystem/attachments/20120407/a7ce6559/attachment.html>
More information about the Kde-buildsystem
mailing list