FindUSB

Yury G. Kudryashov urkud.urkud at gmail.com
Sun Sep 18 11:49:50 UTC 2011


Alexander Neundorf wrote:

> On Sunday, September 18, 2011 10:40:59 AM Yury G. Kudryashov wrote:
>> Yury G.  Kudryashov wrote:
>> > Hi!
>> > 
>> > Reviewboard failed to understand `git diff -M` patch, so I'm sending
>> > both the patch and the new FindUSB.cmake here.
> 
> What's the issue with libusb 0.1 vs. 1.0 ?
See http://libusb.org. Basically, a few years ago they've decided to change 
API/ABI, hence changed the name.

> The whole module doesn't mention any version number. I mean, it does not
> support specifying version numbers (which is acceptable), but it also
> doesn't say that it finds only some specific versions of libusb.
I'll add a comment. Or we can remove this find module.

> I'm not sure I like to have such a warning message there.
libusb-0.1 is not maintained anymore. I think it is good to warn developers 
if they use unmaintained library.

> While you're at it, the first line of the file mentions "freetype" instead
> of libusb.
Fixed in my local version.
-- 
Yury G. Kudryashov,
mailto: urkud at mccme.ru



More information about the Kde-buildsystem mailing list