rfc: FindGStreamer.cmake

Alexander Neundorf neundorf at kde.org
Sat Sep 17 02:11:54 UTC 2011


On Saturday, September 17, 2011 12:59:41 AM Yury G. Kudryashov wrote:
> Hi!
> 
> Please review the attached version of FindGStreamer.cmake. What changed:

The pkgconfig-version checking quite at the top is not indented.

> * Support find_package(GStreamer "0.10.20") (including EXACT)
> * Find GStreamer if pkg-config information is not available (added
> PATH_SUFFIXES to find_path)
> * Do not print debug information, fphsa prints enough.
> * Use lowercase.
> 
> Should we add GSTREAMER_INCLUDE_DIRS to follow cmake/Modules/readme.txt
> recommendations?

It can't hurt.

Alex



More information about the Kde-buildsystem mailing list