Review Request: Make rpc library optional for the NFS slave

[Raphael Kubo da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101664/#review3981
-----------------------------------------------------------

Ship it!


Looks OK to me. lxr says this is the only non-playground place that's not protected (kdm already does its own checks).

- Raphael


On June 17, 2011, 11:36 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101664/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 11:36 p.m.)
> 
> 
> Review request for Build System.
> 
> 
> Summary
> -------
> 
> Allows kde-runtime's kioslave build to skip the NFS subdir on non-Windows machines if rpc library doesn't exist.  Apparently some distros (like gentoo) are distributing the rpc library separately from stock glibc now.
> see https://bugs.gentoo.org/show_bug.cgi?id=371363&list_id=234023
> 
> Seems like this is the only place in KDE SC that is using rpc/rpc.h, but I might be wrong about that.
> 
> 
> Diffs
> -----
> 
>   kioslave/CMakeLists.txt 379ea2d 
> 
> Diff: http://git.reviewboard.kde.org/r/101664/diff
> 
> 
> Testing
> -------
> 
> builds for me.
> 
> 
> Thanks,
> 
> Allen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-buildsystem/attachments/20110617/e11ef345/attachment.htm