[Libstreams] 695554f Specify the full path in LIBSTREAMS_LIBRARIES.

[Raphael Kubo da Costa]

Alexander Neundorf <neundorf at kde.org> writes:

> On Saturday 25 December 2010, Raphael Kubo da Costa wrote:
>> commit 695554fbfcaeb0fbeb47a9196ced6cbd485b4433
>> branch master
>> Author: Raphael Kubo da Costa <kubito at gmail.com>
>> Date:   Sat Dec 25 02:38:35 2010 -0200

<snip>

>> diff --git a/LibStreamsConfig.cmake.in b/LibStreamsConfig.cmake.in
>> index 91bf427..6669b97 100644
>> --- a/LibStreamsConfig.cmake.in
>> +++ b/LibStreamsConfig.cmake.in
>> @@ -2,4 +2,4 @@ set(LIBSTREAMS_FOUND TRUE)
>>  set(LIBSTREAMS_VERSION @LIBSTREAMS_VERSION@)
>>  set(LIBSTREAMS_INCLUDE_DIRS @CMAKE_INSTALL_PREFIX@/include)
>>  set(LIBSTREAMS_LIBRARY_DIRS @LIB_DESTINATION@)
>> -set(LIBSTREAMS_LIBRARIES streams)
>> +set(LIBSTREAMS_LIBRARIES "${LIBSTREAMS_LIBRARY_DIRS}/libstreams.so")
>
> Uh, that doesn't look too good, it hardcodes the "lib" prefix and the ".so"
> suffix. Does that work on Windows ? OSX ?
>
> How can it be done better:
> 1.) use exported targets, then this is done automatically. For this the
> targets have to be put into an "export set" (using the EXPORT argument of
> install(TARGET...)), and then this export set has to be installed (using
> install(EXPORT...) ). The installed export-file can then be included by the
> installed LibStreamsConfig.cmake.

Better late than never :)

Commit 622c6f8f should (hopefully) fix the issue.