kdebase-workspace and QImageBlitz
Michael Jansen
kde at michael-jansen.biz
Sat Jul 30 19:22:02 CEST 2011
Hi
We have a problem here. Even if the module is marked as optional
./CMakeLists.txt:macro_optional_find_package(QImageBlitz)
./CMakeLists.txt:if (QIMAGEBLITZ_FOUND)
./CMakeLists.txt: set(HAVE_QIMAGEBLITZ true)
./CMakeLists.txt:endif (QIMAGEBLITZ_FOUND)
it is universally used as required
[ mjansen @ gambit ][ None ][ 19:18:48 ][
~/kde/trunk/src/KDE/kdebase/workspace ]
[ bash : 1035 ] $ grep -ri --include CMakeLists.txt QIMAGE .
./ksplash/ksplashx/CMakeLists.txt: qimage.cpp
./kcontrol/desktoptheme/CMakeLists.txt:target_link_libraries(kcm_desktoptheme
${QIMAGEBLITZ_LIBRARIES} ${X11_LIBRARIES}
./kcontrol/style/CMakeLists.txt:include_directories( ${QIMAGEBLITZ_INCLUDES} )
./kcontrol/style/CMakeLists.txt:target_link_libraries(kcm_style
${KDE4_KIO_LIBS} ${QIMAGEBLITZ_LIBRARIES}
./ksmserver/tests/CMakeLists.txt:include_directories(
${CMAKE_CURRENT_SOURCE_DIR}/.. ${KDEBASE_WORKSPACE_SOURCE_DIR}/solid/control/
${QIMAGEBLITZ_INCLUDES} )
./ksmserver/tests/CMakeLists.txt:
${KDE4_SOLID_LIBRARY} ${QIMAGEBLITZ_LIBRARIES} ${X11_X11_LIB})
./ksmserver/CMakeLists.txt: ${QIMAGEBLITZ_INCLUDES}
./ksmserver/CMakeLists.txt: ${KDE4_KDEUI_LIBS} ${KDE4_KIO_LIBS}
${QIMAGEBLITZ_LIBRARIES} ${KDE4_SOLID_LIBS} ${X11_LIBRARIES}
${X11_Xrender_LIB}
./kdm/kfrontend/CMakeLists.txt: ${QIMAGEBLITZ_INCLUDES}
./kdm/kfrontend/CMakeLists.txt:target_link_libraries(krootimage
${KDE4_KDEUI_LIBS} ${X11_X11_LIB} ${QIMAGEBLITZ_LIBRARIES})
./kdm/kcm/CMakeLists.txt:include_directories( ${QIMAGEBLITZ_INCLUDES} )
./kdm/kcm/CMakeLists.txt:target_link_libraries(kcm_kdm ${KDE4_KIO_LIBS}
${QIMAGEBLITZ_LIBRARIES} ${KDE4_KNEWSTUFF3_LIBS} ${X11_LIBRARIES} kworkspace)
The question is if it is worth the effort to make it optional again or just
bow to the reality and mark it as required?
Mike
More information about the Kde-buildsystem
mailing list