[kdelibs] cmake/modules: A FindXYZ.cmake file should not use macro_log_feature imho.

[Alexander Neundorf]

On Thursday 30 June 2011, Michael Jansen wrote:
> On Thursday 30 June 2011 22:08:52 Alexander Neundorf wrote:
> > On Wednesday 29 June 2011, Michael Jansen wrote:
> > > Git commit 02e1ba357e730bc6e4a1aa7bf496e880209fdf9d by Michael Jansen.
> > > Committed on 29/06/2011 at 17:28.
> > > Pushed by mjansen into branch 'master'.
> > > 
> > > A FindXYZ.cmake file should not use macro_log_feature imho.
> > 
> > Actually I don't agree.
> > (but I don't object the patch)
> > 
> > I think ideally, each find_package() call should result in the respective
> > information recorded somewhere (i.e. homepage of the project and what
> > that thing is).
> 
> I agree. But only on the first level. Here we have:
> 
> MyApp: find_package(Nepomuk)
> FindNepomuk.cmake: find_package(Soprano)
> 
> So what do you expect the user to see?
> 
> The following optional packages were not found:
> From MyApp    -> Nepomuk(url): Used to ....
> From FindNepomuk.cmake -> Soprano(url): Used to ....

Why not ?
I'd consider that ok.

> I think the second message is not required here. If nepomuk needs soprano
> it should fail with a message why (Nepomuk not found because soprano is
> missing) and myapp should say what missing myapp means for myapp. If
> Nepomuk is not found because nepomuk or soprano is missing is not
> interesting for myapp.
> 
> I hope that makes any sense :((

Yes, it does.
But I think providing more information than strictly necessary is no problem.
 
> And there is the fact that the featuresummary makes only sense for optional
> dependencies. But i could do find_package(Nepomuk REQUIRED) and i think
> adding soprano the feature summary then and not Nepomuk( if myapp forgets
> it) is just confusing.

I don't really understand. Can you please explain ?

Alex