[PATCH] Clean up FindGObject.cmake.
Raphael Kubo da Costa
kubito at gmail.com
Tue Apr 12 00:55:18 CEST 2011
Alexander Neundorf <neundorf at kde.org> writes:
> On Monday 11 April 2011, Raphael Kubo da Costa wrote:
>> * Remove unnecessary WIN32 check.
>> * Use the pkg-config paths as HINTS, not PATHS.
>> * Use FindPackageHandleStandardArgs instead of duplicating its
>> functionality.
>
> Looks good except one thing:
>
> GOBJECT_LIBRARIES is set using SET(), so it is not in the cache, and so it
> doesn't has to be marked as advanced (because normal variables are not at all
> in the cache.
Fixed and committed as e02cae5. Do you see any need to backport it?
More information about the Kde-buildsystem
mailing list