Too strict acl check

Alexander Neundorf neundorf at kde.org
Thu Sep 2 19:02:32 CEST 2010


On Thursday 02 September 2010, Yury G. Kudryashov wrote:
> Alexander Neundorf wrote:
> > On Thursday 02 September 2010, Yury G. Kudryashov wrote:
> >> Hi!
> >>
> >> Check for acl.h fails on my laptop because acl.h contains C++-style
> >> comment, and cmake uses too strict compiler flags.
> >>
> >> What do you think about replacing check_include_files by
> >> check_include_file_cxx?
> >
> > Where is this check ?
>
> kdelibs/cmake/modules/FindACL.cmake

I wouldn't object a makeover of that file:
* maybe the check_include_file() calls are not necessary and instead 
find_file() or find_path() calls would suffice ?
* there should probably be a ACL_INCLUDE_DIR variable
* ACL_LIBS and ATTR_LIBS are not documented, so it should be ok to rename them 
to ACL_ACL_LIBRARY and ACL_ATTR_LIBRARY
* it should use FindPackageHandleStandardArgs

Alex


More information about the Kde-buildsystem mailing list