[PATCH] kdeplasma-addons - only build rss/news plasmoids if rss dataengine is guessed to be available

Maciej Mrozowski reavertm at gmail.com
Wed May 5 03:11:42 CEST 2010


Now it's possible to build and install plasmoids that have runtime only 
dependency on KdepimLibs. This allows to install dysfunctional (as plasma may 
lack RSS dataengine in this case) rss/news plasmoids.
https://bugs.gentoo.org/show_bug.cgi?id=288154

Well, patch does not exactly do what it's supposed to since actually there's 
no way to do CMake check whether RSS dataengine is built and available 
(workspace/plasma), but it tries to guess it from kdepimlibs presence (so it 
fixes issue for those who build plasma and kdeplasma-addons in same build env 
which is common case I think).

Changes in patches:
- build rssnow and news plasmoids when kdepimlibs found (disabling them allows 
to match unsatisfied kdepimlibs deps in kdeplasma-addons with unsatisfied 
kdepimlibs deps in plasma-workspace which provides rss dataengine)
 - remove if(QT_WEBKIT_FOUND) guards to simplify patch and for consistency 
since not all plasmoids needing WebkIt are currently covered by this check 
anyway (not covered: webslice, weather, community in KDE SC 4.4 and 
corresponding trunk plasmoids) so WebKit is pretty much required anyway
- use newer KDEPIMLIBS_<component>_LIBS instead of KDE4_<component>_LIBS
- some minor formatting (only to keep consistency, yeah I know i have a bad 
habit of doing too many changes in the process :P)

Full patches attached

Ok to commit?
(-4.4.3- for 4.4 branch, -4.4.74- for trunk)

-- 
regards
MM
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdeplasma-addons-4.4.74-cmake.patch
Type: text/x-patch
Size: 2623 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100505/2cdf17fa/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kdeplasma-addons-4.4.3-cmake.patch
Type: text/x-patch
Size: 2142 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20100505/2cdf17fa/attachment-0001.patch 


More information about the Kde-buildsystem mailing list