KDE/kdebase/workspace/libs/oxygen

[Aaron J. Seigo]

On March 2, 2010, David Faure wrote:
> On Wednesday 03 March 2010, Aaron J. Seigo wrote:
> > On March 2, 2010, David Faure wrote:
> > > On Tuesday 02 March 2010, Aaron J. Seigo wrote:
> > > > SVN commit 1097981 by aseigo:
> > > > 
> > > > * doesn't link against libplasma
> > > > * don't know what the LIB_MODE thing was for
> > > 
> > > Well, obviously it meant "compile as a static lib on Windows,
> > > and compile as a shared lib on unix", which is sensible for such
> > > a non-public library: we can't use static on unix (-fPIC problem),
> > > but using static on Windows makes sense (one DLL less and no export
> > > macro mess). I suppose.
> > 
> > would it make sense to have something in CMake that could do this for us
> > that could replace SHARED in those statements?
> 
> Well, I'm not sure the case of a "non public DLL" is that common that it's
> worth saving 5 lines in two cmakelists.txt files?

that's why i cc'd the buildsystem list, but my thoughts were if this would 
make it easier to catch all of these in future and be able to introduce 
platform specific behaviours without having to patch each cmake file 
individually.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Development Frameworks