KDE/kdebase/workspace/libs/oxygen

[David Faure]

On Wednesday 03 March 2010, David Faure wrote:
> On Wednesday 03 March 2010, Aaron J. Seigo wrote:
> > On March 2, 2010, David Faure wrote:
> > > On Tuesday 02 March 2010, Aaron J. Seigo wrote:
> > > > SVN commit 1097981 by aseigo:
> > > > 
> > > > * doesn't link against libplasma
> > > > * don't know what the LIB_MODE thing was for
> > > 
> > > Well, obviously it meant "compile as a static lib on Windows,
> > > and compile as a shared lib on unix", which is sensible for such
> > > a non-public library: we can't use static on unix (-fPIC problem),
> > > but using static on Windows makes sense (one DLL less and no export
> > > macro mess). I suppose.
> > 
> > would it make sense to have something in CMake that could do this for us
> > that could replace SHARED in those statements?
> 
> Well, I'm not sure the case of a "non public DLL" is that common that it's
> worth saving 5 lines in two cmakelists.txt files?

Especially since we might make different choices for different non-public DLLs.
E.g. if the compiled code is huge, we might want to still install a DLL on 
Windows, rather than duplicate the code into several other dlls (as a static 
lib does).

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).