kdesupport/automoc

[Patrick Spendrin]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 22.06.2010 20:12, schrieb Alexander Neundorf:
> On Monday 21 June 2010, Patrick Spendrin wrote:
>> Am 21.06.2010 21:52, schrieb Alexander Neundorf:
>>> On Monday 24 May 2010, Alexander Neundorf wrote:
>>>> On Thursday 20 May 2010, Patrick Spendrin wrote:
>>>>> SVN commit 1128891 by sengels:
>>>>>
>>>>> Hack the hack.
>>>>>
>>>>>  M  +3 -0      Automoc4Config.cmake
>>>>>
>>>>>
>>>>> --- trunk/kdesupport/automoc/Automoc4Config.cmake #1128890:1128891
>>>>> @@ -62,6 +62,9 @@
>>>>>  else(EXISTS ${_AUTOMOC4_CURRENT_DIR}/kde4automoc.cpp)
>>>>>     get_filename_component(_AUTOMOC4_BIN_DIR 
>>>>> "${_AUTOMOC4_CURRENT_DIR}" PATH)
>>>>> get_filename_component(_AUTOMOC4_BIN_DIR  "${_AUTOMOC4_BIN_DIR}" PATH)
>>>>> +   if(WIN32)
>>>>> +      get_filename_component(_AUTOMOC4_BIN_DIR  "${_AUTOMOC4_BIN_DIR}
>>>>> REALPATH")
>>>>> +   endif(WIN32)
>>>>
>>>> Why is this necessary ?
>>>
>>> Hmm, I'd still like to know why...
>>>
>>> Alex
>>>
>>> P.S. please keep me on CC
>>
>> simply because g_f_c(.... PATH) will result in '\' if you call it often
>> enough, whereas REALPATH results in 'R:\' (the real path you want to get).
> 
> The code should get the current directory of the Automoc4Config.cmake file, 
> then go two levels up, and then append bin/.
> Why/how can this go wrong ?
> I don't see how this can be called more often ?

As I said already, it doesn't return the correct drive letter with our
current setup (e.g. with subst to shorten the path), but instead just
returns a mere '/' - we want drive letter + ':' + '/' though.


> 
> Alex
> 

regards,
Patrick
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.10 (MingW32)

iEYEARECAAYFAkwhNrgACgkQi49rfdk/G3ZIRgCgtro0NvWo/U0Gcqn6MAMAQGlo
cegAnipHuxKGQHPBCYauJC/50Gkwbc3l
=7VeS
-----END PGP SIGNATURE-----