overriding CMAKE_MODULE_PATH

[Alexander Neundorf]

On Wednesday 18 August 2010, Yury G. Kudryashov wrote:
> Alexander Neundorf wrote:
> > On Monday 16 August 2010, Yury G. Kudryashov wrote:
> >> Alexander Neundorf wrote:
> >> > Hi,
> >> >
> >> > Once I figured that out I tried to make sure that kdelibs and I think
> >> > kdepimlibs stay the only modules which do that.
> >>
> >> Some apps that install files to $prefix/share/apps/cmake/modules:
> >
> > While you're at it, which files are installed and from which
> > CMakeLists.txt ? It seems I noticed these two too late and tried to
> > "limit" the damage: http://websvn.kde.org/?view=revision&revision=966044
> >
> >> kdebase-workspace-4.5.0
>
> All files are installed by cmake/modules/CMakeLists.txt.
>
> >> kdebase-runtime-4.5.0
>
> All files are installed by cmake/modules/CMakeLists.txt.

In both cases (workspace and runtime) these are Find-modules for stuff used by 
kdebase, not built by kdebase.
So it's just not nice, not really wrong.
A package can check whether kdebase is installed, and if it is installed, it 
can assume that these modules are also available.

Maybe they could be moved to kdelibs, at least those from runtime/. This would 
make one module less which installs stuff.

> > Hmm, yes, also not good. But I'm not sure whether not installing it
> > anymore would be a good idea. And they also don't promise compatiblity
> > between versions AFAIK.
> >
> >> kdegraphics-4.5.0
>
> It installs FindOkular and FindKSane which is wrong.
>
> I'm not ready to make "compatibility vs correctness" decisions. Any ideas
> how to fix it in a compatible manner?

Oh, I didn't notice before that these two files are Find-modules for the stuff 
built by kdegraphics, I thought there were used by kdegraphics and also 
installed.
So, this is definitely wrong.
Actually I think there is no compatibility to break.
(Other projects could not guarantee the existence of FindKSane.cmake or 
FindOkular.cmake before, since they couldn't check for it, so they don't even 
break if it's not installed anymore).
But we shouldn't remove it without talking to the maintainers first.

Alex