Wrong check for ktorrent in kdenetwork, Was: Re: overriding CMAKE_MODULE_PATH

Yury G. Kudryashov urkud at ya.ru
Mon Aug 16 21:29:32 CEST 2010

Alexander Neundorf wrote:

> Hi all, Lukas,
>> kdenetwork calls macro_optionally_find_package(KTorrent), and it doesn't
>> stop processing if it fails to find FindKTorrent.cmake.
> This is clearly wrong.
> http://websvn.kde.org/trunk/KDE/kdenetwork/CMakeLists.txt?view=log
> Uh, so we have that in the 4.5 branch ?
Yes, that's why I found it.
> Just put the text below in an otherwise empty CMakeLists.txt and put
> MacroOptionalFindPackage.cmake in the same directory:
> So, a proper FindKTorrent.cmake has to be added to kdenetwork, commit
> 1135222 is wrong, both in trunk and in the 4.5 branch.
Could you please also put FindQJSON.cmake to kdeutils/cmake/modules (the 
same problem, at least in 4.5 branch)?

More information about the Kde-buildsystem mailing list