neundorf at kde.org
Mon Aug 16 21:27:37 CEST 2010
On Monday 16 August 2010, Yury G. Kudryashov wrote:
> kdenetwork/kget/CMakeLists.txt tries to find libkonq and libkworkspace in
> the kdelibs install prefix (with NO_DEFAULT_PATH) and doesn't
> macro_log_feature on failure.
> I have kdelibs, kdebase and kdebase-workspace installed to three different
> locations, so it failed to find both, and it haven't told me about this
> failure in the feature log.
> I propose the following changes (see attached patch):
> 1. Add macro_log_feature.
> 2. Use standard FindLibKonq and FindKDE4Workspace instead of find_library.
> 3. Use macro_optional_find_package.
Looks good from a quick view.
Maybe the messages from the macro_log...() should contain "4" (so it's very
clear that this is about KDE4).
More information about the Kde-buildsystem