overriding CMAKE_MODULE_PATH

[Andreas Pakulat]

On 16.08.10 00:59:20, Yury G. Kudryashov wrote:
> Andreas Pakulat wrote:
> 
> > On 16.08.10 00:09:41, Yury G. Kudryashov wrote:
> >> Alexander Neundorf wrote:
> >> > On Sunday 15 August 2010, Yury G. Kudryashov wrote:
> >> >> Many (all?) KDE modules have the following string in the beginning of
> >> >> CMakeLists.txt:
> >> >>
> >> >> set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/modules)
> >> >>
> >> >> What do you think about replacing this string with the following?
> >> >>
> >> >> set(CMAKE_MODULE_PATH ${CMAKE_SOURCE_DIR}/cmake/modules
> >> >> ${CMAKE_MODULE_PATH})
> >> >>
> >> >> This would allow user to say, e.g.,
> >> >>
> >> >> cmake ${kdenetowrk_src_dir} -
> >> >> DCMAKE_MODULE_PATH=${libktorrent_prefix}/share/apps/cmake/modules
> >> > 
> >> > Why would you want to do that ?
> >> > I think this shouldn't be necessary, and might break more stuff than it
> >> > helps.
> >> Because I have libktorrent installed into a different prefix (not
> >> CMAKE_INSTALL_PREFIX), and kdenetwork fails to find it.
> > 
> > Then either specify CMAKE_PREFIX_PATH for fix the FindKTorrent.cmake
> > module.
> Cmake looks for FindKTorrent in CMAKE_MODULE_PATH, not CMAKE_PREFIX_PATH.

Right. So where is the problem? FindKTorrent.cmake should either be part
of cmake itself, part of kdelibs or be part of kdenetwork. Anything else
is a bug (ktorrent shouldn't install a FindKTorrent.cmake that doesn't
make any sense). As far as I can neither of the three is a case, so I
suggest to add a proper FindKTorrent.cmake to kdenetwork/cmake/modules/.
Then you can use CMAKE_PREFIX_PATH to help that Find-Module find
ktorrent.

Andreas

-- 
Are you sure the back door is locked?