[PATCH] Port from UsePkgConfig to PkgConfig in kdelibs/cmake/modules

Alexander Neundorf neundorf at kde.org
Thu Apr 15 21:41:04 CEST 2010


On Thursday 15 April 2010, Friedrich W. H. Kossebau wrote:
> Hi,
>
> messing around with the buildsystem I stumbled upon the message to port
> away from UsePkgConfig. Trying to gain more experience with cmake I
> produced the attached patches, they seem to work for me.

Very cool, thanks a lot :-)

> The ones for (K)Exiv2, KDCRaw and Kipi were more complex, did I match the
> logic?
>
> Okay to commit, or to be improved before?

If the pkg-config executable hasn't been found, pkg_check_modules() does 
nothing, right ?

FindExiv2.cmake:
set(EXIV2_MIN_VERSION "0.12")
is only in the NOT WIN32 branch, right ? I think at least the setting of this 
variable shouldn't be limited to non-Windows.

FindKIPI.cmake: is KIPI_FOUND set here directly after the results from 
pkg-config, i.e. not by checking the results of the find_path/library() 
calls ? This should be changed. Can you please also have another look at the 
other files whether this is the case there ?

Looking Ok: 
FindGLIB2.cmake
FindKdraw.cmake
FindKexvi2.cmake
FindPopplerQt4.cmake

Alex


More information about the Kde-buildsystem mailing list