Allow a KDE-using project to define its own Qt requirement

[Andreas Pakulat]

On 13.09.09 19:16:07, Alexander Neundorf wrote:
> On Sunday 13 September 2009, Ingo Klöcker wrote:
> > On Sunday 13 September 2009, Andreas Pakulat wrote:
> > > Hi,
> > >
> > > attached patch only sets the QT_MIN_VERSION if its not been set
> > > already. The reason for this is that it may be useful for a project
> > > to require a specific Qt bugfix version (for example if a bug makes
> > > an app unusable). In particular I'd like KDevelop4 to require Qt4.5.2
> > > as we need Qt's raster paintengine for proper performance in the
> > > editor, but that engine still had various crash-bugs in Qt < 4.5.2.
> > >
> > > Comments, Objections?
> >
> > I guess it doesn't really matter in practice, but shouldn't
> > QT_MIN_VERSION be set to the maximum of the already set value and the
> > value hardcoded into FindKDE4Internal?
> 
> Good catch. It probably should do something with if( ... VERSION_GREATER ...) 
> or so.

Right.

> No objections from my side beside this.

Ok, will commit once I'm back under Linux.

Andreas

-- 
Reply hazy, ask again later.