KDE/kdelibs/cmake/modules

[Dario Freddi]

Also (sorry for flooding) just read about the cmake files needed to be sent to 
kde-buildsystem for review. So please, your target is 
cmake/modules/MacroKAuth.cmake.

By the way, what about making these policies more widespread? If it was not 
for Alexander, I would have never known that, and except from him, nobody ever 
pointed me to this. Probably making more developers aware of that would be a 
good move

In data giovedì 03 settembre 2009 19:35:30, Alexander Neundorf ha scritto:
: > ... sending it again, since I assume that Dario is not subscribed to both
> lists
> 
> On Wednesday 02 September 2009, Dario Freddi wrote:
> > SVN commit 1018860 by dafre:
> >
> > Fix installation prefix, still need to spit a warning
> >
> >
> >  M  +4 -1      FindPolkitQt.cmake
> 
> CMake files which go into kdelibs/cmake/modules/ must follow the commit
>  policy we have for them:
>  http://techbase.kde.org/Policies/CMake_Commit_Policy , §7 says "All
>  patches must follow the coding style for CMake files in KDE.", which is
>  here: http://techbase.kde.org/Policies/CMake_Coding_Style
> 
> The PK stuff does not follow these rules.
> There are several issues, please fix them:
> 
> * it works only if pkg_config works:
> http://techbase.kde.org/Policies/CMake_Coding_Style#.28Not.29_Using_pkg-con
> fig
> 
> * it doesn't use a special prefix for the pkg_config variables, this can
>  break stuff and lead to ugly effects:
> http://techbase.kde.org/Policies/CMake_Coding_Style#.28Not.29_Using_pkg-con
> fig
> 
> * I missed the point where the new files were posted for review on
> kde-buildsystem (maybe due to my vacation ?)
> 
> 
> Some things which should be improved (but which are not in the style guide,
> but maybe should be):
> 
> * please license the cmake files under BSD license, as all other our cmake
> files are (reason: cmake is completely BSD licensed, no GPL/LGPL-licensed
> files will be accepted into cmake cvs)
> 
> * please use the find_package_handle_standard_args() macro, if there are no
> real reasons against using it
> 
> * what's up with POLICY_FILES_INSTALL_DIR and
> dbus_add_activation_system_service() ? They are not documented and they
>  don't follow the naming conventions, i.e. they don't start with
>  "POLKITQT_"
> 
> Alex
> 

-- 
-------------------

Dario Freddi
KDE Developer
GPG Key Signature: 511A9A3B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-buildsystem/attachments/20090903/7807da59/attachment-0001.sig