[PATCH] Improve KAuth backend selection and let the packager decide which KAuth backend to compile
neundorf at kde.org
Thu Oct 15 18:23:24 CEST 2009
On Thursday 15 October 2009, Dario Freddi wrote:
> Attaching the patch could probably help you reviewing it
> On Thursday 15 October 2009 16:24:27 Dario Freddi wrote:
> > Hello,
> > the title already says it all. I wanted some review before committing,
> > also because I don't know how's the preferred (and correct) way to let
> > people define some -DSOMETHING on the build line.
the patch could make good use of some more comments, especially a main one
which says what KAUTH_BACKEND is about and how it is supposed to be used.
It would be good if it would show up in the cache, so it is easier to modify
If you say cmake -DFOO=foo, FOO will end up (hidden) in the cache.
If you have then additionally
set(FOO bar CACHE STRING "This is foo")
in the cmake file, this will not override the value given at the command line,
but FOO will be visible and have documentation in the cache.
So you should do that.
More information about the Kde-buildsystem