KDE/kdebase/workspace

[Michael Jansen]

Zitat von David Faure <faure at kde.org>:

> On Wednesday 07 October 2009, Lubos Lunak wrote:
>> On Wednesday 07 of October 2009, David Faure wrote:
>> > On Sunday 04 October 2009, Michael Jansen wrote:
>> > > --- trunk/KDE/kdebase/workspace/startkde.cmake #1031098:1031099
>> > > @@ -384,7 +384,7 @@
>> > >
>> > >  # We set LD_BIND_NOW to increase the efficiency of kdeinit.
>> > >  # kdeinit unsets this variable before loading applications.
>> > > -LD_BIND_NOW=true @LIBEXEC_INSTALL_DIR@/start_kdeinit_wrapper
>> > >  +kcminit_startup
>> > >  +LD_BIND_NOW=true
>> > >  @KDE4_LIBEXEC_INSTALL_DIR@/start_kdeinit_wrapper +kcminit_startup if
>> > > test
>> >
>> > This kills an important performance improvement, I believe.
>> > Lubos, any comments?
>>
>>  It just changes the path (to the same thing anyway), I don't see how it
>> should affect anything.
>
> No, it runs kcminit_startup before kdeinit, so kcminit_startup  
> doesn't benefit
> from the fork+dlopen and other optimizations done by kdeinit.
>
> Ignore the @...@ part, my comment was about the splitting of "kdeinit
> +kcminit_startup" into two lines.

That's just bad luck with formating. If you look at

http://websvn.kde.org/trunk/KDE/kdebase/workspace/startkde.cmake?r1=1000160&r2=1031099&view=patch

You will see that was not done.

http://websvn.kde.org/trunk/KDE/kdebase/workspace/startkde.cmake?r1=1000160&r2=1031099

Does not help either.

Mike

>
> --
> David Faure, faure at kde.org, sponsored by Nokia to work on KDE,
> Konqueror (http://www.konqueror.org), and KOffice (http://www.koffice.org).
>




http://michael-jansen.biz

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.