kdeplasma-addons 4.4/trunk - automagic deps + redundant macro_display_feature_log call

[Maciej Mrozowski]

On Friday 27 of November 2009 06:12:20 Ingmar Vanhassel wrote:
> Excerpts from Maciej Mrozowski's message of Fri Nov 27 05:49:43 +0100 2009:
> 
> Looks sane except for the hunk below:
> > Index: applets/frame/CMakeLists.txt
> > ===================================================================
> > --- applets/frame/CMakeLists.txt    (revision 1054884)
> > +++ applets/frame/CMakeLists.txt    (working copy)
> > @@ -1,11 +1,8 @@
> >  project(plasma-frame)
> > -include (MacroLogFeature)
> >
> >  macro_optional_find_package(Kexiv2)
> >  macro_log_feature(KEXIV2_FOUND "libkexiv2" "Library to access EXIF
> > information" "http://www.kde.org" FALSE "0.2.0" "RECOMENDED: Enables
> > automatic rotation for frame applet" )
> >
> > -macro_display_feature_log()
> > -
> >  set(frame_SRCS
> >      frame.cpp
> >      slideshow.cpp
> 
> Why remove this?

It's redundant. In any other kde4 module/package macro_display_feature_log() 
is called just once at the very end of toplevel CMakeLists.txt to generate 
summary. No need to call it in applets/frame/CMakeLists.txt as well - it only 
pollutes cmake output.
Inclusion of MacroLogFeature is redundant as well, besides this applet (nor 
any other) is supposed to be built standalone so what's the point in 'private' 
summary considering it's impossible to distinguish which cmake project this 
summary belongs to.
What about OpenGL checks? I suppose from now on no features are ever allowed 
to appear in 4.4 branch, so it would be fine to drop unused (and confusing 
packagers) OpenGL checks from kdeplasma-addons.

-- 
regards
MM