Fix create_exe_symlink.cmake for when DESTDIR is set

[Alexander Neundorf]

On Thursday 07 May 2009, Matthew Woehlke wrote:
> ABCD wrote:
> > First off, my apologies if I sent this to the wrong list.
> >
> > Currently, KDE/kdelibs/cmake/modules/create_exe_symlink.cmake calls
> > chmod on the previously installed version of a file when DESTDIR is
> > set, which is incorrect.  It should be calling chmod on the filename
> > under DESTDIR.  This patch (attached) fixes that.
>
> -    EXECUTE_PROCESS(COMMAND chmod a+x ${abs_target})
> +    EXECUTE_PROCESS(COMMAND chmod a+x $ENV{DESTDIR}/${abs_target})
>
> This looks wrong; I don't think you can safely add the / without
> checking if $ENV{DESTDIR} is empty or not. (Remember that the absolute
> paths /usr and //usr are not required to be the same!)


If abs_target is really already an absolute path, I think you don't need the 
slash.

Btw., do you also have another name additionally to ABCD ? ;-)

Alex