Missing configure checks for #cmakedefine

Alexander Neundorf neundorf at kde.org
Wed Mar 25 17:47:16 CET 2009


On Monday 23 March 2009, Lubos Lunak wrote:
> On Saturday 21 of March 2009, Allen Winter wrote:
> > I think someone needs to write a new tool that scans the source for all
> > the conditional compile defines, then compares that list against the list
> > of all the defines we might set (in ConfigureChecks.cmake).
> >
> > This seems more like a code-quality thing than a buildsystem-thing.
>
>  It looks to me like a buildsystem thing, the buildsystem should know
> whether there has been a test for such a flag, since, well, it should know.
> Or at least it could know.
>
> > Hmm.. Krazy could do this, if it was given a list of all known HAVE_FOO
> > macros. Of course, people would also need to care about looking at/fixing
> > Krazy issues on a regular basis.
>
>  I suppose this could be good enough if CMake can't handle this itself.

The code which handles #cmakedefine could test whether the variable is 
actually defined (as opposed to FALSE or OFF), and if not issue a warning.
Please submit a feature request in the cmake bug tracker.

Alex


More information about the Kde-buildsystem mailing list