Missing configure checks for #cmakedefine

[Allen Winter]

On Saturday 21 March 2009 8:25:21 am Allen Winter wrote:
> On Friday 20 March 2009 7:32:12 pm Lubos Lunak wrote:
> > On Friday 20 of March 2009 23:21:48 Thiago Macieira wrote:
> > > Lubos Lunak wrote:
> > > >At least looking at generated
> > > >kdebase/workspace/config-workspace.h it has a couple of #undef's for
> > > > things that obviously are present (e.g. unistd.h).
> > >
> > > unistd.h is not present on Windows (it's not a Unix system). But workspace
> > > is not meant to compile on Windows anyways...
> > 
> >  I think you misunderstood my point. I am pretty sure there is unistd.h on my 
> > machine. Just like there is setpriority(), yet the code requiring it wasn't 
> > compiled.
> > 
> 
> I think someone needs to write a new tool that scans the source for all
> the conditional compile defines, then compares that list against the list
> of all the defines we might set (in ConfigureChecks.cmake).
> 
> This seems more like a code-quality thing than a buildsystem-thing.
> 
> Hmm.. Krazy could do this, if it was given a list of all known HAVE_FOO macros.
> Of course, people would also need to care about looking at/fixing Krazy issues on a regular basis.
> 
> I will do a Krazy check, if people want me to do that.
> 
Done.  Will be in place for tonight's run on the EBN.

-- 
Allen Winter | Software Engineer | 1-888-872-9339
KDAB, Inc. | "Platform-independent software solutions"
http://kdab.com | 1-866-777-5322 (US) | +46-563-540090 (Sweden)