Missing configure checks for #cmakedefine

Lubos Lunak l.lunak at suse.cz
Fri Mar 20 22:46:33 CET 2009


 Hello,

 it's been pointed out to me that KDE4 runs screensavers at normal priority 
(thus possibly affecting other sessions on the same machine). The code uses 
setpriority() call, which is inside #ifdef HAVE_SETPRIORITY. And, while, 
kdebase/workspace/config-workspace.h.cmake has HAVE_SETPRIORITY, there is 
nothing to actually do the check[*]. It somehow got lost during KDE4 porting, 
and there are possibly more places. At least looking at generated 
kdebase/workspace/config-workspace.h it has a couple of #undef's for things 
that obviously are present (e.g. unistd.h).

 Is there some way to avoid this kind of problem? With the way these things 
are scattered in KDE4 this is rather difficult to check.

[*] Already fixed.

-- 
Lubos Lunak
KDE developer
--------------------------------------------------------------
SUSE LINUX, s.r.o.   e-mail: l.lunak at suse.cz , l.lunak at kde.org
Lihovarska 1060/12   tel: +420 284 028 972
190 00 Prague 9      fax: +420 284 028 951
Czech Republic       http://www.suse.cz



More information about the Kde-buildsystem mailing list