-mms-bitfields revisited

[Alexander Neundorf]

On Tuesday 16 June 2009, Till Adam wrote:
> Guys, ladies, questioning and/or transitioning folk and those who transcend
> gender categories,
>
> please find attached two patches, one against the cmake findkde4internl
> module in kdelibs, one against kdesupport's top level CMakeLists.txt, which
> add the use of -mms-bitfields to the C and CXX flags when building with/for
> mingw. The need for them was brought to our attention by a nasty bug caused
> by incompatible memory layouts between gpgme and gpgme++/qgpgme due to
> their (gnupg's) use of this flag. They use it, because all of their
> depedencies have it (notably gtk) and a somewhat in-depth google confirms
> that that seems to be pretty standard practise, among those shipping for
> mingw. It basically tell gcc to be msvc compatible, for C libs, if I
> understand correctly, and should cause no harm, provided everything is
> built with it consistently. I guess it makes sense for KDE to go with the
> majority opinion here. Ultimately I lack insight and overview in this
> matter, though, so I'd like to hear your (kde- buildsystem's) opinions.

No objections from the cmake side, but I can't judge about the usefulness etc.

Alex