[PATCH] akonadi can't be built in kdesupport

[Matthew Woehlke]

Alexander Neundorf wrote:
> On Saturday 13 June 2009, Matthew Woehlke wrote:
>> Index: akonadi/cmake/modules/FindSoprano.cmake
>> ===================================================================
>> --- akonadi/cmake/modules/FindSoprano.cmake     (revision 981221)
>> +++ akonadi/cmake/modules/FindSoprano.cmake     (working copy)
>> @@ -37,6 +37,16 @@
>>   #  set(SopranoIndex_FOUND TRUE)
>>
>>   #else(SOPRANO_INCLUDE_DIR AND SOPRANO_LIBRARIES AND
>> SOPRANO_INDEX_LIBRARIES AND SOPRANO_SERVER_LIBRARIES)
>> +# Are we using this inside kdesupport ?
>> +# Then expect that Soprano is also part of kdesupport:
>> +if(KDESupport_SOURCE_DIR)
>> +  set(SOPRANO_INCLUDE_DIR ${KDESupport_SOURCE_DIR}/soprano)
>> +  set(SOPRANO_INDEX_LIBRARIES sopranoindex)
>> +  set(SOPRANO_CLIENT_LIBRARIES sopranoclient)
>> +  set(SOPRANO_LIBRARIES soprano)
>> +  set(SOPRANO_SERVER_LIBRARIES sopranoserver)
> 
> That doesn't work, since you also need the soprano libraries when building 
> akonadi, and you don't know whether soprano has been already built, so with 
> this it will fail at build time (which is worse than at cmake time).

Huh? The above should be cmake targets, so cmake should handle the 
dependencies, yes? At least, it seems to work for every other cmake 
project I've built...

Obviously soprano needs to be parsed first in kdesupport/CMakeLists.txt 
(and it currently is - with a comment that it must be that way, even), 
but I don't see that as a problem...

-- 
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
-- 
End of Transmission